Skip to content

fix files.json trailing commas #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2021
Merged

fix files.json trailing commas #655

merged 1 commit into from
Mar 24, 2021

Conversation

Neradoc
Copy link
Contributor

@Neradoc Neradoc commented Mar 24, 2021

Fixes error on json.load().

makermelissa
makermelissa reviewed Mar 24, 2021
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Since this file is auto-generated, is this likely to be an issue in the future?

jepler
jepler approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot checked and the changes look okay

@jepler jepler merged commit 499b1d7 into adafruit:master Mar 24, 2021
@dhalbert
Copy link
Collaborator

Thanks for fixing this. Since this file is auto-generated, is this likely to be an issue in the future?

This was my fault. It doesn't normally contain trailing commas. I had to edit it by hand due to adafruit/circuitpython#4470

dhalbert
dhalbert reviewed Mar 24, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Neradoc Neradoc deleted the fix-languages-list branch May 5, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa left review comments

@dhalbert dhalbert dhalbert left review comments

@jepler jepler jepler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Neradoc @dhalbert @jepler @makermelissa