Skip to content

Allow custom builds to disable CDC, MSC in a better way #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jepler opened this issue Jun 24, 2020 · 1 comment
Closed

Allow custom builds to disable CDC, MSC in a better way #3065

jepler opened this issue Jun 24, 2020 · 1 comment

Comments

@jepler
Copy link

jepler commented Jun 24, 2020

In #3038 @dhalbert suggested that it would be beneficial to allow CDC and MSC to be disabled just like MIDI and HID can be now. He gives a rationale there.

So:

  • Add CIRCUITPY_USB_CDC and CIRCUITPY_USB_MSC
  • Check them at various sites as appropriate to disable code and/or built in modules
  • Use them to compute the USB_DEVICES string, instead of always including CDC and MSC
    • A Makefile trick to deal with not getting a leading comma will be necessary
  • When done, remove the ability to directly specify USB_DEVICES, it's unneeded at that point.

Note that this does not mean the CircuitPython definition is changing e.g., to allow devices without MSC into the core! However, we do wish to enable people to make custom builds that are not in the core that have these disabled for various reasons.

@jepler jepler added this to the Long term milestone Jun 24, 2020
@dhalbert
Copy link
Collaborator

Fixed by #4689 and previous PR's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants