Added patch to remove duplicate code from libs that have it #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattni
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
@evaherrada Please verify those libraries are still passing once this patch is run. If they are not, verify that the min-similarity-lines in .pylintrc has been updated to 12. If they are still not, please file an issue and tag me on it and we'll figure out what we want to do. Other libs so far, 12 has been sufficient for them to pass.
|
Will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
44 libraries have duplicate-code disabled for the pylint check on the libraries. This patch will remove that for those libraries.