Fix [-Wrestrict] bug #289
Merged
Fix [-Wrestrict] bug #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Untested...
hathach
approved these changes
Apr 2, 2021
Member
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
spotted on, strcpy and memcpy are declared with restricted pointer, they may have optimization that causes issue with overlapped memory. For example using uint32_t copy/assign on 32-bit platform.
Member
|
Let me know when you think the PR is ready for review/merge. The changes look good to me. |
Author
|
I must ask for help to test this. Real life prevents me from testing this soon. My hope is it's simple enough to test. I am happy to mark this ready for review, knowing you will test this before merge. |
hathach
requested changes
Apr 6, 2021
Member
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
need logic change in the for loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #253, where the issue is well documented.
WARNING: ENTIRELY UNTESTED (although trivial) CODE.