Skip to content

Add Repka Pi-3 H5 and Pi-4 H6 constants #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

mahenzon
Copy link
Contributor

@mahenzon mahenzon commented Jan 6, 2024

Hi. I'd like to add support for Repka-Pi boards

@mahenzon mahenzon force-pushed the feature/add-repka-pi branch from 458627f to 197c36d Compare January 6, 2024 12:16
@mahenzon
Copy link
Contributor Author

mahenzon commented Jan 6, 2024

I see that the check fails on the Build assets step in the tests job. The error says "Only a single package is supported". I checked the circuitpython-build-tools and the error text is defined here:
https://github.com/adafruit/circuitpython-build-tools/blob/152702f7f20c38add11fa6715b77d8cc391ceb7b/circuitpython_build_tools/build.py#L211

It gets packages here:
https://github.com/adafruit/circuitpython-build-tools/blob/152702f7f20c38add11fa6715b77d8cc391ceb7b/circuitpython_build_tools/build.py#L195

And in this project packages are defined here:

packages = ["adafruit_platformdetect", "adafruit_platformdetect.constants"]

This line wasn't edited here, so the error is not caused by this PR.

Is there anything I can do to make the pipelines green?

@makermelissa
Copy link
Collaborator

I see that the check fails on the Build assets step in the tests job. The error says "Only a single package is supported". I checked the circuitpython-build-tools and the error text is defined here: https://github.com/adafruit/circuitpython-build-tools/blob/152702f7f20c38add11fa6715b77d8cc391ceb7b/circuitpython_build_tools/build.py#L211

Not your fault. It was an accidental carryover in GitHub Actions. It should be fixed now.

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good.

@makermelissa makermelissa merged commit 9384e45 into adafruit:main Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants