Skip to content

Add Orange Pi 5 Plus (again?) #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Conversation

Barbarian-5215
Copy link
Contributor

Sorry, first timer here.

I made the requested changes to my original request, then I hit the [close with comment], which I believe closed the first pull request.

This is a new pull request, with the changes included. I hope this is correct. BTW, I've been coding for 40 years and this is my first experience with git - pretty awesome!

Thanks,
Tom

Added a constant for ORANGE_PI_5_PLUS
Added detection of Orange Pi 5 Plus
Changed order of discovery, 5 plus, then 5.
Added literal definition for ORANGE_PI_5_PLUS
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good. In the future, you can reopen your original request and just push changes and it updates automatically.

@makermelissa makermelissa merged commit 2c5a187 into adafruit:main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants