Added support for Olimex A20-LIME2-EMMC Board #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2023
makermelissa
requested changes
Nov 28, 2023
adafruit_platformdetect/board.py
Outdated
| @@ -947,6 +955,7 @@ def lazily_generate_conditions(): | |||
| yield self.board.QTPY_U2IF | |||
| yield self.board.QT2040_TRINKEY_U2IF | |||
| yield self.board.KB2040_U2IF | |||
| yield self.board.lime2 | |||
There was a problem hiding this comment.
This probably shouldn't be here. the os_environ boards require an environment variable to be detected, but it looks like you are looking in board value already for detection.
| @@ -24,7 +24,7 @@ | |||
| BEAGLELOGIC_STANDALONE = "BEAGLELOGIC_STANDALONE" | |||
| OSD3358_DEV_BOARD = "OSD3358_DEV_BOARD" | |||
| OSD3358_SM_RED = "OSD3358_SM_RED" | |||
|
|
|||
| LIME2 = "LIME2" | |||
There was a problem hiding this comment.
Just to make it super clear, can you change this to something like "OLIMEX_LIME2"? Thanks
|
okay, hopefully I have done the changes correctly and fixed the reference everywhere. |
makermelissa
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed a previous pull request. This is a new one.
I started from scratch and hopefully did everything correctly.
The code works properly for my application.