Added Improved Pi Revision Code Detection #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
approved these changes
May 12, 2023
Comment on lines
+242
to
+296
| @property | ||
| def overvoltage(self): | ||
| """Overvoltage allowed/disallowed""" | ||
| return self._get_property("overvoltage") | ||
|
|
||
| @property | ||
| def warranty_bit(self): | ||
| """Warranty bit""" | ||
| return self._get_property("warranty") | ||
|
|
||
| @property | ||
| def otp_program(self): | ||
| """OTP programming allowed/disallowed""" | ||
| return self._get_property("otp_program") | ||
|
|
||
| @property | ||
| def otp_read(self): | ||
| """OTP reading allowed/disallowed""" | ||
| return self._get_property("otp_read") | ||
|
|
||
| @property | ||
| def rev_style(self): | ||
| """Revision Code style""" | ||
| # Force new style for Rev Style | ||
| return self._get_rev_prop_value("rev_style") | ||
|
|
||
| @property | ||
| def memory_size(self): | ||
| """Memory size""" | ||
| return self._get_property("memory_size") | ||
|
|
||
| @property | ||
| def manufacturer(self): | ||
| """Manufacturer""" | ||
| return self._get_property("manufacturer") | ||
|
|
||
| @property | ||
| def processor(self): | ||
| """Processor""" | ||
| return self._get_property("processor") | ||
|
|
||
| @property | ||
| def type(self): | ||
| """Specific Model""" | ||
| return self._get_property("type") | ||
|
|
||
| @property | ||
| def type_raw(self): | ||
| """Raw Value of Specific Model""" | ||
| return self._get_property("type", raw=True) | ||
|
|
||
| @property | ||
| def revision(self): | ||
| """Revision Number""" | ||
| return self._get_property("revision") |
There was a problem hiding this comment.
You could use a Data Descriptor class to factor these all out. (Works like CP Register does.)
There was a problem hiding this comment.
Thanks, I'll have to take a look at that. I'm not familiar with it.
There was a problem hiding this comment.
I think since this has been well tested as it is and I don't feel confident with descriptors, I'd rather use this as a starting point. That could be a future improvement.
makermelissa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #268.
This adds a revision code decoder to the Pi which can accurately check the model and revision number of the Raspberry Pi revision code along with some other information about it. This works for both new style and old style codes.
I added rpi_info.py, which if run on a Pi, it will display all the info for the device and if run on something else, it will prompt for a code to decode. I also added rev_code_tester.py, which will run through all the existing codes, run that code through the decoder, and check if it matches what is expected, which it does with 100% accuracy. By decoding it can ignore many of the similar variations of codes.
This also adds detection for the new CM4S modules.