Skip to content

add/amend frequency comments #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jerryneedell merged 1 commit into from
Dec 20, 2018
Merged

add/amend frequency comments #12

jerryneedell merged 1 commit into from
Dec 20, 2018

Conversation

@brentru
Copy link
Member

@brentru brentru commented Dec 20, 2018

  • Edit frequency comments in the AS, and EU863 TTN regions and add comments to the US902 frequency plan file.

This is to avoid confusion of what the tuple's correspond to and bring incorrect frequency comments in-line with the correct TTN freqs.

jerryneedell
jerryneedell approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@jerryneedell jerryneedell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do you want me to merge?

@jerryneedell jerryneedell merged commit 8063358 into adafruit:master Dec 20, 2018
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 20, 2018
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@6455912)
3ef080d 
Updating https://github.com/adafruit/Adafruit_CircuitPython_TinyLoRa to 1.0.4 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#12 from brentru/fix-freq-comments
  > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#11 from brentru/example-spi-ordering
  > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#10 from philwilkinson40/patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#6 from brentru/readme-modification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryneedell jerryneedell jerryneedell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brentru @jerryneedell