Use os.path.join to concatenate paths
#30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Dec 20, 2020
|
nice! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 21, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_AS7341 to 1.0.2 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#5 from anecdata/url Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.5.2 from 1.5.1: > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#30 from orderthruchaos/join_paths_instead_of_concat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying out the slideshow library for Adabox016, I noticed that the
folderargument required a trailing slash in order to work properly (from the example code:folder="/images"would fail,folder="/images/"would succeed). Usingos.path.join(folder, f)instead offolder + ffixes this issue.