Fixed Travis Errors and Disabled no-member #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattni
suggested changes
Feb 12, 2019
There was a problem hiding this comment.
This is great! Thank you! You did it perfectly. I think however, in the case of these short examples, we're going to do it "incorrectly" to keep the examples cleaner. In 99% of cases, this is exactly how I would want it done, but there's already so little to these examples that doing it properly doesn't make the most sense for readability.
examples/slideshow_simpletest.py
Outdated
|
|
||
| # Create the slideshow object that plays through once alphabetically. | ||
| #pylint: disable=no-member |
There was a problem hiding this comment.
Please place this below the imports.
examples/slideshow_simpletest.py
Outdated
| slideshow = SlideShow(board.DISPLAY, pulseio.PWMOut(board.TFT_BACKLIGHT), folder="/", | ||
| loop=False, order=PlayBackOrder.ALPHABETICAL) | ||
| #pylint: enable=no-member |
examples/slideshow_touch.py
Outdated
|
|
||
| forward_button = touchio.TouchIn(board.TOUCH4) | ||
| back_button = touchio.TouchIn(board.TOUCH1) | ||
|
|
||
| brightness_up = touchio.TouchIn(board.TOUCH3) | ||
| brightness_down = touchio.TouchIn(board.TOUCH2) | ||
|
|
||
| #pylint: disable=no-member |
examples/slideshow_touch.py
Outdated
| slideshow = SlideShow(board.DISPLAY, pulseio.PWMOut(board.TFT_BACKLIGHT), folder="/", | ||
| auto_advance=False, dwell=0) | ||
| #pylint: enable=no-member |
kattni
suggested changes
Feb 12, 2019
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 19, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#7 from brentru/expose-requests-more Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.0.3 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#12 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#10 from tannewt/update_for_4 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_Bitmap_Font, Adafruit_CircuitPython_Display_Text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11.