Fix StreamHandler behavior #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After this it may be worth removing the manual adding of |
|
@Neradoc let me know if this solution works for your use/test cases |
FoamyGuy
approved these changes
Jul 9, 2022
There was a problem hiding this comment.
Looks good to me. Tested successfully on Feather ESP32 S2 TFT.
Adafruit CircuitPython 8.0.0-alpha.1-30-g8814ee03f-dirty on 2022-07-01; Adafruit Feather ESP32-S2 TFT with ESP32S2
>>>
>>> import adafruit_logging as logging
>>> logger = logging.getLogger('test')
>>> logger.error('Error message')
1295.777: ERROR - Error message
>>>
Thanks for the fix @tekktrik and reporting the issue @Neradoc
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 10, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3MDL to 1.1.16 from 1.1.15: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3MDL#20 from tekktrik/fix/remove-duplicate-info Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 4.1.2 from 4.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_Logging#34 from tekktrik/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33 by:
StreamHandleras handler to newLoggerinstances usinggetLogger()by default\ntoStreamHandler.emit()so log lines are seperated onto newlines