change to forward reference for possibly unbound symbols in type hint(s) #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
reviewed
Oct 6, 2025
FoamyGuy
reviewed
Oct 6, 2025
pantheraleo-7
changed the title
FoamyGuy
reviewed
Nov 12, 2025
| from micropython import const | ||
|
|
||
| try: | ||
| import typing |
Contributor
There was a problem hiding this comment.
I think having this attempt at importing typing or something from it is still necessary for our purposes to prevent imports used only for typing from actually getting imported on microcontrollers in order to save RAM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on ADS1x15#101(comment)