Ensure the headers are not modified in HTTPResponse #27
Conversation
spovlot
changed the title
|
as the author of #26 I can confirm this fixes the content length. And as far as I can see, the capitalization issue too |
|
Functionally, it shouldn't matter, but should we be consistent between request and response in the use of case for headers? |
The HTTP Standard states that header names are case-insensitive - https://www.rfc-editor.org/rfc/rfc9110.html#section-5.1-3 . The issue #27 manifested itself as a case issue. But I think that was a side effect related to the overwriting of the passed in object. |
|
agree with @spovlot as well that changing the dictionary values are the root cause of the issue noted and the fix from this change. case consistency could be discussed and / or changed in the future still independent from this fix. |
Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90640 to 1.2.14 from 1.2.13: > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#30 from tcfranks/main > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.12.16 from 1.12.15: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#70 from BiffoBear/add_typing > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#27 from spovlot/response-header-overwrite > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 5.1.0 from 5.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_Logging#44 from vladak/multiple_handlers > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Fix for issue #26 which was caused by the passed in headers dict getting modified for the response. Then the calling program reused the headers in subsequent calls. Thanks to @dhalbert and @anecdata for assistance on Discord.