-
Notifications
You must be signed in to change notification settings - Fork 12
Added NeoPixel FeatherWing #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
814b0af
Added NeoPixel FeatherWing. Modified DotStar Lib.
a6bbcca
Restructured DotStar and NeoPixel to use common base class
b862de5
Linting
c5522d5
Undid class split. Linting.
bb1bf82
Final Linting
8f8d345
fixed merge conflict
e7f836d
Changed display to matrix
aef49c4
Linting
b3cd6e3
Merge branch 'neopixel'
c9b8582
Neopixels and DotStars using Base Class
08b9662
Fixed Base Class
570bfe9
Disabled bugged Lint Messages
f16b992
Merge branch 'neopixel2'
20f1c9b
Moved PixelMatrix to separate class
a74a071
Merge branch 'neopixel2'
4162737
Removed a lot of the overriding functions
dd7dc3f
Merge branch 'neopixel2'
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider naming this
matrix
instead ofdisplay
as we have a lot of display libraries within which we use that term. There are some FeatherWings with displays (or maybe only one?) and it might be a little confusing.