Skip to content

change dht context to static var for linux #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2018
Merged

change dht context to static var for linux #20

merged 2 commits into from
Dec 2, 2018

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Dec 1, 2018

linux pulsein would have to launch process for each pulsein, which takes a while, better and more reliable to keep it running.

also tested on py3 on a trinket m0

@ladyada ladyada requested a review from a team December 1, 2018 07:13
kattni
kattni approved these changes Dec 2, 2018
View reviewed changes
Copy link

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the update!

@kattni kattni merged commit 507f643 into adafruit:master Dec 2, 2018
@ladyada
Copy link
Member Author

ladyada commented Dec 2, 2018

ok thanks @kattni - wanna do a release?

@kattni
Copy link

kattni commented Dec 2, 2018

Sure I was going to leave it for the sweet tomorrow, but I can do it now. On it!

@ladyada
Copy link
Member Author

ladyada commented Dec 2, 2018

ooh thank uuu

tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 3, 2018
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@6086fba)
7e54ad6 
Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.2.2 from 3.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#20 from ladyada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_FRAM to 1.2.0 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_FRAM#4 from sommersoft/spi_new
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattni kattni kattni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ladyada @kattni