Add missing type annotations #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
requested changes
Oct 3, 2022
adafruit_bno055.py
Outdated
| return tuple(self.scale * v for v in result) | ||
|
|
||
| def __set__(self, obj, value): | ||
| def __set__(self, obj, value) -> None: |
Contributor
There was a problem hiding this comment.
should the obj and value here have types? In the set function a little below here it has int and str for their types, would it be the same for this one?
Contributor
Author
There was a problem hiding this comment.
Must of missed them? In ny until the weekend with just my phone, so nothing in this till then
Contributor
Author
|
resubmitted get and set changes |
FoamyGuy
approved these changes
Oct 10, 2022
Contributor
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks again.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 11, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.4.7 from 5.4.6: > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#108 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM69 to 2.1.13 from 2.1.12: > Merge pull request adafruit/Adafruit_CircuitPython_RFM69#42 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.19.9 from 1.19.8: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#76 from The-Debarghya/bug-75-zerodivisionerror Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 4.2.0 from 4.1.6: > Merge pull request adafruit/Adafruit_CircuitPython_Logging#40 from tekktrik/dev/allow-root-logger Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 5.5.2 from 5.5.1: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#122 from calcut/fetch_all_messages_in_loop Updating https://github.com/adafruit/Adafruit_CircuitPython_PYOA to 2.5.12 from 2.5.11: > Merge pull request adafruit/Adafruit_CircuitPython_PYOA#37 from tekktrik/dev/fix-install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #85
submitted for review / comment