feat: add url_components for start/end #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
feat-add-url-components
branch
2 times, most recently
from
1f3f36a to
037f54b
Compare
|
Let me try to do a PR on top to express my ideas. |
|
Please see #251 |
|
With such a component, it could be fruitful to restructure the main ada/url. It could be made of a single string (which might possibly be identical to the input) along with this url_component. It could make the main ada/url structure smaller and faster. We could then boost our performance (e.g., by 25% or so). |
lemire
approved these changes
Mar 1, 2023
|
We also do not have all the tests for this. Let's finish them before merging this. |
|
It would be good to have a plan to see where this is going. I started a discussion issue: #253 |
|
We are using a combination of |
lemire
reviewed
Mar 3, 2023
* Some proposed changes. * Minor simplicification.
anonrig
force-pushed
the
feat-add-url-components
branch
from
e53ea26 to
9dacf36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.