Skip to content

PR Fall 2021 Updates #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 29, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
# [siggraph website](https://acm-uiuc.github.io/siggraph/)
The ACM-UIUC SIGGraph Website

Create-react-app + Bootstrap v4
(Create-react-app + Bootstrap v4)

## Contributing
To contribute to the site, you must be a part of SIGGraph UIUC:
1. Make changes to https://github.com/SIGGraph-UIUC/siggraph, a fork of the original acm-uiuc repository
2. Test those changes via `$ yarn run start` which creates a local development server
3. Use a Pull Request to merge those changes to the master branch
4. Upon approval, have someone run
```
$ git checkout master
$ git pull
$ yarn run deploy
```
They should then check that the deployment at https://siggraph-uiuc.github.io/siggraph looks correct.
5. Finally, you can make a PR from the fork to the original repository
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"react-dom": "^16.8.6",
"react-feather": "^2.0.9",
"react-router-dom": "^5.0.1",
"react-scripts": "^3.0.1",
"react-scripts": "^4.0.3",
"react-stack-grid": "^0.7.1",
"react-youtube": "^7.9.0",
"three": "^0.106.2"
Expand Down
Binary file added public/assets/hi_tea.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion public/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,4 @@
-->
</body>

</html>
</html>
Binary file added public/models/teapot.fbx
Binary file not shown.
8 changes: 1 addition & 7 deletions src/App.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,9 @@
import React, { Component } from "react";

import Background from "./Background";

class App extends Component {
render() {
const { width, height } = this.props.size;
return (
<div className="App">
<Background width={width} height={height} />
<h1 className="center w-100">SIGGRAPH @ UIUC</h1>
</div>
<img className="poster" style ={{width: '100%'}} src={process.env.PUBLIC_URL + '/assets/hi_tea.png'} alt="hi tea poster" />
);
}
}
Expand Down
5 changes: 4 additions & 1 deletion src/Background.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,16 @@ class Background extends Component {
// ADD CUBE
let that = this;
const loader = new FBXLoader();
loader.load("models/index.fbx", function(object) {
//switched to teapot for now
loader.load("models/teapot.fbx", function(object) {
object.traverse(function(child) {
if (child.isMesh) {
child.castShadow = true;
child.receiveShadow = true;
}
});


that.scene.add(object);
that.cube = object;
that.start();
Expand Down
24 changes: 23 additions & 1 deletion src/Navigation.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,12 @@ class Navigation extends Component {
return (
<Router basename="/"> {/* When using HashRouter, we don't need the public URL as a basename */}
<Switch>
<DefaultLayout exact path="/" component={App} size={this.state} />
{/*
PosterLayout is like DefaultLayout but without a Container component. This allows the poster to stretch
the full length of the screen. When the front page has a poster, use PosterLayout for App. Otherwise
use DefaultLayout.
*/}
<PosterLayout exact path="/" component={App} size={this.state} />
<DefaultLayout
path="/projects"
component={Projects}
Expand Down Expand Up @@ -72,6 +77,23 @@ const DefaultLayout = ({ component: Component, size, ...rest }) => {
);
};

const PosterLayout = ({ component: Component, size, ...rest }) => {
return (
<Route
{...rest}
render={matchProps => (
<>
<div className="main-container">
<Header />
<Component {...matchProps} size={size} />
<Footer />
</div>
</>
)}
/>
);
};

const Construction = () => <h1>This page is under construction</h1>;

const NotFound = () => (
Expand Down
4 changes: 2 additions & 2 deletions src/data/data.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,5 +65,5 @@ export const about = {
},
],
meeting:
"Join us for meetings on Discord Mondays 5-6PM CST!"
};
"Join us for meetings Monday in Siebel CS Center Rm 1103 4pm - 5pm CST!"
};
Loading