Skip to content

Conversation

NadaElmasry
Copy link

Overview

This draft PR introduces the integration of the EEG2BIDS and SET2BIDS backends. The current implementation is still undergoing testing, so the original backend has not been removed yet. Once testing is complete and both the Backend and Frontend have been fully validated, the old backend will be deprecated and removed.

Key Changes

  • Separation of Logic: The code now separates the EDF and SET file handling logic into distinct classes, each inheriting from a new BaseHandler class. This structure improves code organization and maintainability.

Ongoing Adjustments:

  • Further modifications to these classes are anticipated based on the outcomes of ongoing testing, code reviews, and any additional requirements that may arise.

Next Steps

  • Final Testing: Continue testing the new backend integration with both the Frontend and Backend to ensure stability and functionality.

  • Code Refinement: Address any issues uncovered during testing and incorporate feedback from code reviews.

  • Deprecation of Old Backend: Once the new implementation is verified, the old backend code will be removed.

@NadaElmasry NadaElmasry changed the title Draft PR: EEG2BIDS and SET2BIDS Backend Integration EEG2BIDS and SET2BIDS Backend Integration Aug 12, 2024
@christinerogers
Copy link
Collaborator

@NadaElmasry a push here is needed from you.
Please share what you have been working as soon as you can (this PR is in draft mode.)

@christinerogers
Copy link
Collaborator

christinerogers commented Nov 1, 2024

this version is working (Nada), more runs worked.
Ready to test and review

First things to test @NadaElmasry . Use the group slack including Jefferson if stuck on this:

  • Test Loris interaction : use Nada's sandbox localhost : your username on your sandbox
    - Ensure you have Enabled API (use screenshot laetitia showed - how to update token)
  • Test EEG Recording Parameters - a simple example is here

More cleanup - ideally for Monday Nov.4:

  • remove the old backend
  • clean up the new backend
  • double-check linter noise, revert what is not relevant to the intended code changes

Known issues:
serious backend lag (even on files that didn't lag on old version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants