-
Notifications
You must be signed in to change notification settings - Fork 3
fix: merge context attributes when setting them #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe PR bumps Absmartly::VERSION from "1.2.0" to "1.2.1"; changes ContextConfig#set_attributes to merge incoming attributes into existing Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧬 Code graph analysis (1)spec/context_spec.rb (2)
🔇 Additional comments (2)
✏️ Tip: You can disable this entire section by setting Comment |
|
Note Docstrings generation - SUCCESS |
Docstrings generation was requested by @calthejuggler. * #29 (comment) The following files were modified: * `lib/context_config.rb`
48255dd to
2731c62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@absmartly.gemspec`:
- Line 35: The gemspec adds an unnecessary runtime dependency "base64" even
though the code only uses Ruby's standard library method
Digest::MD5.base64digest (see lib/hashing.rb); remove the spec.add_dependency
"base64" entry unless you intentionally need the external gem for Ruby 3.4+
compatibility, in which case add a version constraint (e.g., "~> 0.3") and a
brief comment explaining it's only for future Ruby versions.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Gemfile.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
absmartly.gemspec
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/main.yml:
- Line 8: The matrix currently lists "ruby-version: [ '2.7', '3.0', '3.1',
'3.2', '3.3', '3.4' ]" which can cause intermittent failures for 2.7; update the
workflow to handle 2.7 specially by either adding a matrix include for '2.7'
that pins runs-on to a stable runner (e.g., set runs-on: ubuntu-20.04 for that
include), or mark the 2.7 job as non-blocking by adding continue-on-error: true
for the 2.7 entry, or remove '2.7' from the ruby-version matrix if support is no
longer required; apply the change where the matrix and job definitions reference
ruby-version and runs-on to ensure only the 2.7 job gets the special handling.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/main.yml
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
This PR fixes a bug where
context.set_attributeswas not working correctly, and improves Ruby 3.4 compatibility.Bug Fix
Previously we were using
||=optional object assignment, but becauseattributesis initialised as an empty object, this would essentially do nothing.The fix is to switch it to
merge!, and I have added some tests to ensure it.Compatibility & CI Fixes
base64gem dependency with version constraint (~> 0.2) for Ruby 3.4+ where it's no longer a default gem (required by Faraday 2.7.x which uses base64 internally but doesn't declare it as a dependency)rexmlto fix CI dependency resolutionclient_config.rbVersion: 1.2.1
Summary by CodeRabbit
Bug Fixes
Improvements
Tests
Chores
Version: 1.2.1
✏️ Tip: You can customize this high-level summary in your review settings.