October 2025 #235
October 2025 #235
Conversation
chris-absmartly
requested review from
bmsilva,
calthejuggler,
marcio-absmartly and
mario-silva
as code owners
WalkthroughUpdates October 2025 platform release notes: introduces a team-centric ownership model with four built-in roles (Team Viewer, Team Contributor, Team Admin, Base User), role inheritance across child teams, and current immutability with future custom roles. Clarifies no behavioural change unless users are added to teams; global roles remain valid. Documents onboarding via /settings/teams and scope across entities owned by teams. Adds exposure management option to ignore events via __ignore. Notes fixes to experiment re-export and metric list UI. Announces upcoming 2KB JSON payload limit for goal/exposure events and outreach on historical large payloads. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for absmartly-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/platform-release-notes/2025/10.mdx (1)
10-11: Capitalise the role names consistently.The list below introduces “Team Contributor”, “Team Viewer”, and “Team Admin”, so it would read more cleanly if the inline sentence reused the same capitalisation.
-You can now assign users to teams and grant them **team-level roles** — such as Team contributor, Team viewer, or Team admin — that define how they interact with experiments, metrics, goals, templates, and features owned by that team. +You can now assign users to teams and grant them **team-level roles** — such as Team Contributor, Team Viewer, or Team Admin — that define how they interact with experiments, metrics, goals, templates, and features owned by that team.docs/platform-release-notes/2025/06.mdx (1)
41-44: Remove the duplicated “Improve searchability” line.The standalone sentence repeats the first bullet verbatim, so dropping it will tighten the section without losing meaning.
-Improve searchability and filtering (archived vs. unarchived) - - Improve searchability and filtering (archived vs unarchived)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
docs/platform-release-notes/2025/03.mdx(3 hunks)docs/platform-release-notes/2025/04.mdx(1 hunks)docs/platform-release-notes/2025/05.mdx(1 hunks)docs/platform-release-notes/2025/06.mdx(4 hunks)docs/platform-release-notes/2025/07.mdx(2 hunks)docs/platform-release-notes/2025/08.mdx(1 hunks)docs/platform-release-notes/2025/09.mdx(1 hunks)docs/platform-release-notes/2025/10.mdx(1 hunks)docs/web-console-docs/events.mdx(1 hunks)
calthejuggler
force-pushed
the
October-2025
branch
from
ca035e9 to
9fb9dc0
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
docs/platform-release-notes/2025/10.mdx (5)
10-10: Use consistent title‑case for role names.Align with the bullet list below.
-You can now assign users to teams and grant them **team-level roles** — such as Team contributor, Team viewer, or Team admin — that define how they interact with experiments, metrics, goals, templates, and features owned by that team. +You can now assign users to teams and grant them **team-level roles** — such as Team Contributor, Team Viewer, or Team Admin — that define how they interact with experiments, metrics, goals, templates, and features owned by that team.
12-12: Standardise spelling (behaviour vs behavior).The doc mixes en-GB (“organisation”) and en-US (“behavior”). Pick one house style; if en-GB, switch “behavior” -> “behaviour” here.
-Unless you explicitly add users to teams and assign them roles, there should be **no changes in behavior** and everything will continue working as before. +Unless you explicitly add users to teams and assign them roles, there should be **no changes in behaviour** and everything will continue working as before.Confirm which variant your docs follow globally (en-GB vs en-US).
24-24: Minor wording: lifecycle and start/stop.More idiomatic and concise.
- Can do everything a Team Viewer can, plus create/edit experiments, features, templates, metrics, and goals within the team and manage the life cycle (start, stop) of those experiments and features. + Can do everything a Team Viewer can, plus create/edit experiments, features, templates, metrics, and goals within the team, and manage the lifecycle (start/stop) of those experiments and features.
36-36: Make the settings path a clickable link and tighten phrasing.Also remove the colon before the path.
-If you haven't started yet, you can begin managing your team hierarchy at: `/settings/teams` +If you haven't started yet, you can begin managing your team hierarchy at [/settings/teams](/settings/teams).Confirm the route is correct for all deployments (cloud/self‑hosted).
47-49: Softer, clearer failure wording.- Fixed an issue where re-exporting experiment data for an existing export request would break the export process. + Fixed an issue where re‑exporting experiment data for an existing export request could cause the export to fail.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/platform-release-notes/2025/10.mdx(1 hunks)
🔇 Additional comments (4)
docs/platform-release-notes/2025/10.mdx (4)
3-5: Overview reads well.Clear summary and intent. No issues.
34-35: Clarify “Global Team” term and inheritance precedence.If “Global Team” is a product term, consider linking to its docs and clarify effective permission when roles are set at multiple levels (union vs most‑permissive vs most‑restrictive).
Optionally append:
- All existing global roles remain valid and can be assigned at the **Global Team level**, which represents your organisation. Team role permissions are **inherited**: roles granted at any level apply to all child teams. + All existing global roles remain valid and can be assigned at the **Global Team level**, which represents your organisation. Team role permissions are **inherited**: roles granted at any level apply to all child teams. When roles are granted at multiple levels, the most permissive effective permission applies.
44-46: Specify how to use__ignore.State expected type and placement to avoid ambiguity.
Consider amending:
- You can now tag exposure events with a `__ignore` attribute to have them excluded from experiment analysis. This is useful for excluding internal users from your experiments. + You can now tag exposure events with a `__ignore` attribute to have them excluded from experiment analysis. Set `__ignore: true` in the event payload. This is useful for excluding internal users from your experiments.Are nested locations supported, or must
__ignorebe a top‑level boolean?
55-59: Clarify the 2 KB limit measurement and handling.Please specify:
- How size is computed (JSON‑encoded bytes? character count?).
- What happens to oversize events (rejected with status code vs silently dropped vs truncated).
- Effective date and version (next release date).
Suggested clarifications to add:
- “Size is measured as the number of bytes of the JSON‑encoded payload.”
- “Events exceeding 2 KB will be [rejected with HTTP 413 | dropped server‑side] and not processed.”
- “This change takes effect in the [Month YYYY] release.”
Added release notes for october 2025
Summary by CodeRabbit