-
-
Notifications
You must be signed in to change notification settings - Fork 113
Support ignored_resources attribute in ABOUT files #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyanSinhaMahapatra
added a commit
that referenced
this pull request
Jul 14, 2023
Reference: #809 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
a063b87
to
366c66b
Compare
AyanSinhaMahapatra
added a commit
that referenced
this pull request
Jul 14, 2023
Reference: #809 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
366c66b
to
3495553
Compare
AyanSinhaMahapatra
added a commit
that referenced
this pull request
Jul 14, 2023
Reference: #809 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
3495553
to
4f970a4
Compare
tdruez
requested changes
Jul 14, 2023
AyanSinhaMahapatra
added a commit
that referenced
this pull request
Jul 14, 2023
Reference: #809 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
4f970a4
to
a3379b9
Compare
AyanSinhaMahapatra
added a commit
that referenced
this pull request
Jul 14, 2023
Reference: #809 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
a3379b9
to
9763d58
Compare
Reference: #809 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
9763d58
to
f6981cf
Compare
@tdruez thanks for the feedback, I have addressed these now. All green and ready for review again! |
tdruez
reviewed
Jul 17, 2023
tdruez
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #809