Skip to content

Update pyproject.toml #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

janvdp
Copy link
Contributor

@janvdp janvdp commented Sep 14, 2023

Additional PR for #684

Updated pyproject.toml to read the version dynamically following the setuptools docs: https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html

Add dynamic version to pyproject.toml
@abetlen
Copy link
Owner

abetlen commented Sep 14, 2023

Hey @janvdp from version 0.2 on I started using the dynamic metadata regex tool from https://scikit-build-core.readthedocs.io/en/latest/configuration.html#dynamic-metadata to set the version which is now found in the root __init__.py file.

@janvdp
Copy link
Contributor Author

janvdp commented Sep 15, 2023

@abetlen Aha, thanks for the info. I did not know. Had a look at the docs, found it a little obscure, but if it works, let's roll.

Safe to reject/delete this PR.

@janvdp janvdp closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants