FIX: Bug in threshold tollerance calculation for determining similarity #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following lines:
As
x(the difference between the two thresholds) is a ratio oft, thentshould be the tollerance above which two thresholds are considred different. The tollerance may be proportional to the threshold, e.g.PERMISSIBLE_DELTA * condition1.threshold, butPERMISSIBLE_DELTA * condition1.threshold + condition1.thresholdmakes no sense (e.g. consider the case wherecondition1.thresholdis negative).