-
Notifications
You must be signed in to change notification settings - Fork 269
feat: update create_text_message_object() to accept other input parameters
#519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
agilyol
wants to merge
14
commits into
a2aproject:main
Choose a base branch
from
agilyol:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+70
−2
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ff8b93d
Fix missing extensions from protobuf
yolagil b7906f8
Update src/a2a/utils/proto_utils.py
agilyol 8a0196c
update create_text_message_object function to handle all inputs
yolagil b236530
update docstrings
yolagil 4c2b78f
Update src/a2a/client/helpers.py
agilyol e6d806e
Update src/a2a/client/helpers.py
agilyol 1211d73
add test
yolagil 275f124
fix linter
yolagil 54f3af9
fix linter
yolagil 85d0c9e
fix extension links
yolagil 3d0288d
update
yolagil 1a35a16
revert all proto proto_utils changes
yolagil dc44d96
Merge branch 'main' into main
agilyol 5d60e93
Formatting
holtskinner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,32 @@ | ||
| """Helper functions for the A2A client.""" | ||
|
|
||
| from typing import Any | ||
| from uuid import uuid4 | ||
|
|
||
| from a2a.types import Message, Part, Role, TextPart | ||
|
|
||
|
|
||
| def create_text_message_object( | ||
| role: Role = Role.user, content: str = '' | ||
| role: Role = Role.user, | ||
| content: str = '', | ||
| extensions: list[str] | None = None, | ||
| metadata: dict[str, Any] | None = None, | ||
| ) -> Message: | ||
| """Create a Message object containing a single TextPart. | ||
|
|
||
| Args: | ||
| role: The role of the message sender (user or agent). Defaults to Role.user. | ||
| content: The text content of the message. Defaults to an empty string. | ||
| extensions: The extensions of the message. Defaults to an empty list. | ||
| metadata: The metadata of the message. Defaults to an empty dictionary. | ||
|
|
||
| Returns: | ||
| A `Message` object with a new UUID message_id. | ||
| """ | ||
| return Message( | ||
| role=role, parts=[Part(TextPart(text=content))], message_id=str(uuid4()) | ||
| role=role, | ||
| parts=[Part(TextPart(text=content))], | ||
| message_id=str(uuid4()), | ||
| extensions=extensions or [], | ||
| metadata=metadata or {}, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there is much value in adding additional tests for the
send_messagemethod here, but it introduces unnecessary complexity. Could you directly test thecreate_text_message_objectfunction?