Merge master fork #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor the ShortcutReader and WineShortcutReader classes - add a short documentation page for how to write classes inside scripts
I will add libncurses 32 bits in the runtime also since I founded why it did not work, but it needs this.
- refactor the InstallerScript class
- refactor the GOGScript class
- refactor the wine engine implementation code - make change version wizard title translatable
- refactor the wine engine object - add some more error messages
- change all scripts to use the new module system - move wine version strings to new script - add missing explicit includes - move WINE_PREFIX_DIR to new constants script - remove now unneeded globals from .eslintrc - remove unused includes from scripts - update documentation pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.