Skip to content

Added guard against HTMLElement in callSubscriber #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
netsgnut wants to merge 1 commit into from
Closed

Added guard against HTMLElement in callSubscriber #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# Unreleased

### Misc

- Added guard against undefined `HTMLElement` in `callSubscriber` for SSR

# [7.0.0](https://github.com/ZeeCoder/use-resize-observer/compare/v6.1.0...v7.0.0) (2020-11-11)

### Bug Fixes
Expand Down
4 changes: 2 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function useResolvedElement<T extends HTMLElement>(
element = callbackRefElement.current;
} else if (refElement.current) {
element = refElement.current;
} else if (refOrElement instanceof HTMLElement) {
} else if (typeof HTMLElement !== "undefined" && refOrElement instanceof HTMLElement) {
element = refOrElement;
}

Expand All @@ -59,7 +59,7 @@ function useResolvedElement<T extends HTMLElement>(
}
};

if (refOrElement && !(refOrElement instanceof HTMLElement)) {
if (refOrElement && typeof HTMLElement !== "undefined" && !(refOrElement instanceof HTMLElement)) {
// Overriding the default ref with the given one
ref = refOrElement;
}
Expand Down