forked from Code-Sharp/WampSharp
-
Notifications
You must be signed in to change notification settings - Fork 1
Close more consistently #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Minimaximize
wants to merge
22
commits into
wampv3
Choose a base branch
from
Liam/Bugs/CloseMoreConsistently
base: wampv3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent multiple calls of close from creating orphan TaskCompletionSources
This may indicate that the session has not yet authenticated or is still awaiting a welcome message. In this case, Abort should be used to terminate the session
This previously would have resulted in close throwing a WampConnectionBroken exception despite the fact that close was initated by the router
Author
|
It occurred to me as I was making the pull request that I may have been aborting the connection to the server incorrectly (instead calling On that note, There is an issue where the |
Allow the state of the underlying transport to be seen, rather than only knowing if a session has been successfully established
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that calling close does not result in orphan tasks which will never be completed.
Previously each call of
Close(details, reason)would result in themCloseTaskfield inWampSessionClientbeing overwritten with a new task completion source, meaning previous calls toClosecould no longer be completed as the session client no longer had access to the underlyingTaskCompletionSourceChanges
Helloto the server) throws aWampSessionNotEstablishedExceptionWelcomemessage has been issued) will instead call Abort