Skip to content

Conversation

@chalkie11
Copy link

No description provided.

@chalkie11 chalkie11 closed this Apr 8, 2025
@Yawan-1
Copy link
Owner

Yawan-1 commented Apr 9, 2025

Why did you close it? The changes you made was fine and better.

@Yawan-1 Yawan-1 reopened this Apr 9, 2025
@chalkie11
Copy link
Author

I made the PR without testing. It failed when deploying on Vercel (404 error), so more tweaking needed probably. But yes, the code to load environment variables is definitely worth merging. You may want to change your DB details also, seeing as they've been committed.

@@ -0,0 +1,29 @@
# versel.json
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the file name be versel.json or vercel.json? Also technically a comment in JSON does not work.

@Yawan-1
Copy link
Owner

Yawan-1 commented Apr 10, 2025

@chalkie11 Are you deploying this on Vercel? Good luck for that! And Yeah DB details should be updated. I think I remember it now, a developer changed the DB configurations with their own conf. some time ago. Good from my side as you updated it for good.

If you need any assistance or stuck into some problem while deplying this project then please let me know.

@lahwaacz You're right, it should be vercel.json not versel.json. Thanks for pointing that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants