Use mlir-python-extras as a dependency #1828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunhoffe
changed the title
Closed
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
hunhoffe
changed the title
hunhoffe
changed the title
|
Waiting on makslevental/mlir-python-extras#101 |
|
Should be ready to go now! |
hunhoffe
requested review from
AndraBisca,
denolf,
fifield,
jackl-xilinx,
jgmelber and
stephenneuendorffer
as code owners
|
I was going to wait to merge until #1835 was in, so this PR would be tested with that, but it's taking a while so I did the test locally with quick_setup and it worked for me, so I'll go ahead and merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes code in
mlir-aie/python/extrasthat is currently present inmlir-python-extrasand usesmlir-python-extrasas a dependency. To differentiate more clearly between what is inmlir-python-extrasand what is added, I also separated the import paths; theextrasfrom the external library are found ataie.extras, as before. The additional code that is useful for this project but potentially not upstream-able/applicable formlir-python-extrashas been moved toaie.helpers. I'm open to naming suggestions if there are better ideas than this!The installation of
mlir-python-extrasis not as clean as I would like, because to build the python api wheels, dependencies are installed via therequirements.txtfile; however, the requirements are parsed in a way that is incompatible with requirements installed via github repos (which is howmlir-python-extrasis installed). I think the truly correct way to fix this is to change how we handle dependencies in the wheels; I'm not sure if this is in the scope of this PR or not. I'm happy to get advice.