Skip to content

EmitC: Add emitc.global and emitc.get_global #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 25, 2024

Conversation

mgehre-amd
Copy link
Collaborator

This adds

  • emitc.global and emitc.get_global ops to model global variables similar to how memref.global and memref.get_global work.
  • translation of those ops to C++
  • lowering of memref.global and memref.get_global into those ops

This adds
- `emitc.global` and `emitc.get_global` ops to model global variables
similar to how `memref.global` and `memref.get_global` work.
- translation of those ops to C++
- lowering of `memref.global` and `memref.get_global` into those ops
@mgehre-amd mgehre-amd requested a review from TinaAMD March 21, 2024 10:39
@mgehre-amd mgehre-amd requested a review from TinaAMD March 25, 2024 12:37
@mgehre-amd mgehre-amd requested a review from TinaAMD March 25, 2024 14:30
@mgehre-amd mgehre-amd requested a review from TinaAMD March 25, 2024 15:36
Copy link

@TinaAMD TinaAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgehre-amd mgehre-amd enabled auto-merge (squash) March 25, 2024 15:50
@mgehre-amd mgehre-amd merged commit c98ce04 into feature/fused-ops Mar 25, 2024
@mgehre-amd mgehre-amd deleted the matthias.emitc_global branch March 25, 2024 15:50
mgehre-amd added a commit that referenced this pull request Apr 15, 2024
This adds
- `emitc.global` and `emitc.get_global` ops to model global variables
similar to how `memref.global` and `memref.get_global` work.
- translation of those ops to C++
- lowering of `memref.global` and `memref.get_global` into those ops
mgehre-amd added a commit that referenced this pull request Apr 26, 2024
This adds
- `emitc.global` and `emitc.get_global` ops to model global variables
similar to how `memref.global` and `memref.get_global` work.
- translation of those ops to C++
- lowering of `memref.global` and `memref.get_global` into those ops

---------

Co-authored-by: Simon Camphausen <[email protected]>
mgehre-amd added a commit that referenced this pull request Apr 30, 2024
This adds
- `emitc.global` and `emitc.get_global` ops to model global variables
similar to how `memref.global` and `memref.get_global` work.
- translation of those ops to C++
- lowering of `memref.global` and `memref.get_global` into those ops

---------

Co-authored-by: Simon Camphausen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants