Skip to content

Conversation

@pierrevalade
Copy link
Contributor

  • use Audio type
  • ..

@pierrevalade
Copy link
Contributor Author

I'm still working on this PR -- a few examples with tools are not working right now, maybe because of:

https://linear.app/workflowai/issue/WOR-3810/max-tool-iterations-reached

@pierrevalade
Copy link
Contributor Author

@guillaq could you please check the failing lint test please? thank you!

@pierrevalade pierrevalade requested a review from guillaq March 6, 2025 20:17
@pierrevalade
Copy link
Contributor Author

I'm still working on this PR -- a few examples with tools are not working right now, maybe because of:

https://linear.app/workflowai/issue/WOR-3810/max-tool-iterations-reached

fixed 👍

@pierrevalade
Copy link
Contributor Author

@guillaq ready for review! thanks, would love to understand where the lint error is coming from.

@pierrevalade pierrevalade marked this pull request as ready for review March 6, 2025 20:18
@guillaq
Copy link
Collaborator

guillaq commented Mar 6, 2025

would love to understand where the lint error is coming from.

Agent function needed to be async. Which is a requirement we could remove.

The pyright error is really unclear but there is not much we can do about it

guillaq
guillaq previously approved these changes Mar 6, 2025
@pierrevalade
Copy link
Contributor Author

would love to understand where the lint error is coming from.

Agent function needed to be async. Which is a requirement we could remove.

oh yeah! makes sense thanks!

@pierrevalade pierrevalade requested a review from guillaq March 7, 2025 03:01
@pierrevalade
Copy link
Contributor Author

@guillaq I think you can review again, and merge, thank you!

Copy link
Contributor Author

I accepted the suggestion you did — but then something happened with the lint — you can go ahead and fix directly! 🙂 thank you!

@guillaq guillaq merged commit 9116ae6 into main Mar 7, 2025
5 checks passed
@guillaq guillaq deleted the pierre-examples-improvements branch March 7, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants