Skip to content

Conversation

sejas
Copy link
Collaborator

@sejas sejas commented Nov 17, 2022

Proposed Changes

Before this PR when you run npm install you get the following errors:

wordpress-wasm trunk ❯ npm install
npm ERR! code EINVALIDPACKAGENAME
npm ERR! Invalid package name "@microsoft/api-extractor-model " of package "@microsoft/api-extractor-model @7.25.2": name cannot contain leading or trailing spaces; name can only contain URL-friendly characters.

Testing Instructions

  • run npm install
  • Observe the dependencies has been installed and there are no errors.

@sejas
Copy link
Collaborator Author

sejas commented Nov 17, 2022

@adamziel, could you take a look at this PR?

I had to remove these empty spaces to be able to install and run the project.

I love this project 💪 .

@adamziel
Copy link
Collaborator

Yay, great fix @sejas – thank you!

@adamziel adamziel merged commit 895a06f into WordPress:trunk Nov 18, 2022
@sejas sejas deleted the fix/remove-spaces-package-json branch November 21, 2022 14:20
bgrgicak added a commit that referenced this pull request May 7, 2025
## Motivation for the change, related issues

Add `exif` support to PHP-wasm to bring Playground closer to feature
parity with PHP.

## Implementation details

To enable Exif, this PR passes a `--enable-exif` argument when
configuring PHP during PHP-wasm build.
Because Exif requires Mbstring, it will be enabled if Exif is enabled. 

## Testing Instructions (or ideally a Blueprint)

- CI

---------

Co-authored-by: Adam Zieliński <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants