Fix typo in readme #68
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonpayton
added a commit
that referenced
this pull request
Feb 28, 2025
## Motivation for the change, related issues When I enabled source maps for the website build in [bba856f](bba856f), the source maps were inadvertently added to the list of assets required for working offline. Source maps are not needed to run Playground offline, and they can be quite large. So we need to remove them from the list. ## Implementation details This PR adds a new exclusion pattern so source maps are no longer included in `assets-required-for-offline-mode.json`. ## Testing Instructions (or ideally a Blueprint) - On trunk, build the website and save a copy of `dist/packages/playground/wasm-wordpress-net/assets-required-for-offline-mode.json` - Switch to this branch, rebuild the website, and save another copy of the above JSON file. - Confirm that there are no .js.map files referenced in the second JSON file. - On the command line run `diff <(cat old.json | sort) <(cat new.json | sort)` and confirm that the only differences are .js.map files missing from the second JSON file.
brandonpayton
added a commit
that referenced
this pull request
Feb 28, 2025
## Motivation for the change, related issues When I enabled source maps for the website build in [bba856f](bba856f), the source maps were inadvertently added to the list of assets required for working offline. Source maps are not needed to run Playground offline, and they can be quite large. So we need to remove them from the list. ## Implementation details This PR adds a new exclusion pattern so source maps are no longer included in `assets-required-for-offline-mode.json`. ## Testing Instructions (or ideally a Blueprint) - On trunk, build the website and save a copy of `dist/packages/playground/wasm-wordpress-net/assets-required-for-offline-mode.json` - Switch to this branch, rebuild the website, and save another copy of the above JSON file. - Confirm that there are no .js.map files referenced in the second JSON file. - On the command line run `diff <(cat old.json | sort) <(cat new.json | sort)` and confirm that the only differences are .js.map files missing from the second JSON file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.