Keep wordpress-importer.zip for older versions of Playground #2647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older versions of Playground currently rely upon playground.wordpress.net resources like /wordpress-importer.zip. Even if someone is self-hosting a version Playground web app, there are some hardcoded resource URLs for playground.wordpress.net. Ideally, we will make all these URLs relative to the self-hosted origin, but in the meantime, let's put the wordpress-importer.zip back on playground.wordpress.net.
adamziel
deleted the
restore-wp-importer-zip-for-folks-on-previous-versions
branch
Collaborator
|
Thank you, really good spot! |
Member
Author
|
Thanks, @adamziel! I'll trigger a new web app deploy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Older versions of Playground currently rely upon
playground.wordpress.netresources like https://playground.wordpress.net/wordpress-importer.zip. Even if someone is self-hosting a version of Playground web app, there are some hard-coded resource URLs for playground.wordpress.net.When ec4dc2b was merged and the latest version of Playground stopped depending the Humanmade wordpress-importer fork, we removed the zip file from our website, which broke Playground imports for folks self-hosting an older version or relying on older package versions.
Ideally, we will make all these URLs relative to the self-hosted origin, but in the meantime, let's put the
wordpress-importer.zipfile back on playground.wordpress.net.Implementation details
This PR restores wordpress-importer.zip and the web server config for serving it.
Testing Instructions (or ideally a Blueprint)
cc @adamziel