[Website] Split boot logic into Blueprints v1 and v2 flows (similar to CLI) #2626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lling compileBlueprint()
adamziel
force-pushed
the
remove-boot-overrides
branch
from
39927d8 to
e6d9cad
Compare
Collaborator
Author
|
I like where this is going. The next step here could be extracting generic Blueprint v1/v2 handler and worker classes and reusing them between Playground web and Playground CLI. This would give us a lot for free: consistent logic, reusable features, less opportunity to make mistakes, ... |
Collaborator
Author
|
This is essentially merged in smaller chunks via other PRs, e.g. #2657 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
🚧 Work in progress 🚧
Brings the website Playground boot flows closer to CLI ones wehre Blueprints v1 and v2 are handled by separate client and worker classes.
Implementation details
Testing Instructions (or ideally a Blueprint)