[PHP] Expose php.cli() on the web #2590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR ships the web wasm binaries with the `run_cli` C function that enables calling php.cli(). Intertwining the CLI SAPI usage with the web SAPI usage was impractical before #2559, but now we can easily call `await php.cli(); await php.run()` on the same PHP instance. Note this PR does not expose the `.cli()` method to the public yet. It only ships the updated WASM binaries to unlock that. ## Testing instructions CI
adamziel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
This PR:
php.cli()method for in-browser PHP.wasm consumerssandboxedSpawnHandlerFactory()that callsphp.cli()and is consistent across all Playground runtimes.For context on what makes this possible, see #2589 and #2559.
Testing Instructions (or ideally a Blueprint)
CI