Skip to content

[PHP-wasm] File mounting in NODEFS #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jul 17, 2025
Merged

[PHP-wasm] File mounting in NODEFS #2338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
6e093a7
Mount tests
bgrgicak Jul 8, 2025
1e38f50
Create directory node before mounting
bgrgicak Jul 8, 2025
6619235
When mounting a file create a empty file node instead of a directory …
bgrgicak Jul 9, 2025
8ac28d2
Remove the restriction which allows only directory mounting during co…
bgrgicak Jul 9, 2025
6a42ec1
Recompile PHP 8.0 Asyncify used by the mount and symlink test
bgrgicak Jul 9, 2025
deb9f85
Create mount point only if lookup throws error ENOENT
bgrgicak Jul 9, 2025
d18f5fa
Remove node created by mount after unmount
bgrgicak Jul 9, 2025
652563a
Test symlink mounting
bgrgicak Jul 9, 2025
b428d85
Fix symlink mounting and copying
bgrgicak Jul 14, 2025
2ae32b1
File operations
bgrgicak Jul 15, 2025
d52b3b4
Directory operations
bgrgicak Jul 15, 2025
868316e
Add symlinked directory and file tests
bgrgicak Jul 15, 2025
8f637e9
Merge branch 'trunk' into add/file-mounting-to-nodefs
bgrgicak Jul 15, 2025
9517bc5
Revert mountNODEFSMountPoint
bgrgicak Jul 15, 2025
d3ab7b7
Remove debug logs
bgrgicak Jul 15, 2025
cbdc543
Replace mount directory condition only once
bgrgicak Jul 15, 2025
ffbac8a
Fix linter issues
bgrgicak Jul 15, 2025
8c95634
Revert unrelated lint changes
bgrgicak Jul 15, 2025
bd97546
Remove TODO
bgrgicak Jul 15, 2025
1c180c5
Rename mounting to mount
bgrgicak Jul 15, 2025
4f6fda4
Don't create directories manually before mounting to NODEFS
bgrgicak Jul 15, 2025
84e2e07
Merge branch 'trunk' into add/file-mounting-to-nodefs
bgrgicak Jul 15, 2025
9dd8ea4
Recompile PHP-wasm Node
bgrgicak Jul 15, 2025
7fa179c
Update packages/php-wasm/compile/php/Dockerfile
bgrgicak Jul 16, 2025
952c6d6
Address feedback
bgrgicak Jul 16, 2025
648696c
Fix linter errors
bgrgicak Jul 16, 2025
1fd538b
Create parent directory before creating the mount node
bgrgicak Jul 16, 2025
4521055
Don't follow symlinks when checking for a mountpoint in rmdir
bgrgicak Jul 16, 2025
caf7606
Merge branch 'trunk' into add/file-mounting-to-nodefs
bgrgicak Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/php-wasm/compile/php/Dockerfile
View file
Open in desktop
Binary file modified packages/php-wasm/node/asyncify/7_2_34/php_7_2.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified packages/php-wasm/node/asyncify/7_3_33/php_7_3.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified packages/php-wasm/node/asyncify/7_4_33/php_7_4.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified packages/php-wasm/node/asyncify/8_0_30/php_8_0.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified packages/php-wasm/node/asyncify/8_1_23/php_8_1.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified packages/php-wasm/node/asyncify/8_2_10/php_8_2.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified packages/php-wasm/node/asyncify/8_3_0/php_8_3.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified packages/php-wasm/node/asyncify/8_4_0/php_8_4.wasm
View file
Open in desktop
Binary file not shown.
22 changes: 7 additions & 15 deletions packages/php-wasm/node/asyncify/php_7_2.js
View file
Open in desktop
22 changes: 7 additions & 15 deletions packages/php-wasm/node/asyncify/php_7_3.js
View file
Open in desktop
22 changes: 7 additions & 15 deletions packages/php-wasm/node/asyncify/php_7_4.js
View file
Open in desktop
679 changes: 475 additions & 204 deletions packages/php-wasm/node/asyncify/php_8_0.js
View file
Open in desktop
22 changes: 7 additions & 15 deletions packages/php-wasm/node/asyncify/php_8_1.js
View file
Open in desktop
22 changes: 7 additions & 15 deletions packages/php-wasm/node/asyncify/php_8_2.js
View file
Open in desktop
22 changes: 7 additions & 15 deletions packages/php-wasm/node/asyncify/php_8_3.js
View file
Open in desktop
22 changes: 7 additions & 15 deletions packages/php-wasm/node/asyncify/php_8_4.js
View file
Open in desktop
Binary file modified packages/php-wasm/node/jspi/7_2_34/php_7_2.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified packages/php-wasm/node/jspi/7_3_33/php_7_3.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified packages/php-wasm/node/jspi/7_4_33/php_7_4.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified packages/php-wasm/node/jspi/8_0_30/php_8_0.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified packages/php-wasm/node/jspi/8_1_23/php_8_1.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified packages/php-wasm/node/jspi/8_2_10/php_8_2.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified packages/php-wasm/node/jspi/8_3_0/php_8_3.wasm
View file
Open in desktop
Binary file not shown.
Binary file modified packages/php-wasm/node/jspi/8_4_0/php_8_4.wasm
View file
Open in desktop
Binary file not shown.
25 changes: 12 additions & 13 deletions packages/php-wasm/node/jspi/php_7_2.js
View file
Open in desktop
25 changes: 12 additions & 13 deletions packages/php-wasm/node/jspi/php_7_3.js
View file
Open in desktop
25 changes: 12 additions & 13 deletions packages/php-wasm/node/jspi/php_7_4.js
View file
Open in desktop
25 changes: 12 additions & 13 deletions packages/php-wasm/node/jspi/php_8_0.js
View file
Open in desktop
25 changes: 12 additions & 13 deletions packages/php-wasm/node/jspi/php_8_1.js
View file
Open in desktop
25 changes: 12 additions & 13 deletions packages/php-wasm/node/jspi/php_8_2.js
View file
Open in desktop
25 changes: 12 additions & 13 deletions packages/php-wasm/node/jspi/php_8_3.js
View file
Open in desktop
25 changes: 12 additions & 13 deletions packages/php-wasm/node/jspi/php_8_4.js
View file
Open in desktop
13 changes: 12 additions & 1 deletion packages/php-wasm/node/src/lib/load-runtime.ts
View file
Open in desktop
49 changes: 48 additions & 1 deletion packages/php-wasm/node/src/lib/node-fs-mount.ts
View file
Open in desktop
526 changes: 526 additions & 0 deletions packages/php-wasm/node/src/test/mount.spec.ts
View file
Open in desktop
24 changes: 11 additions & 13 deletions packages/php-wasm/node/src/test/php.spec.ts
View file
Open in desktop
10 changes: 0 additions & 10 deletions packages/php-wasm/node/src/test/rotate-php-runtime.spec.ts
View file
Open in desktop
1 change: 0 additions & 1 deletion packages/php-wasm/node/src/test/symlinks.spec.ts
View file
Open in desktop
19 changes: 19 additions & 0 deletions packages/php-wasm/universal/src/lib/fs-helpers.ts
View file
Open in desktop
117 changes: 62 additions & 55 deletions packages/php-wasm/universal/src/lib/php.ts
View file
Open in desktop
19 changes: 14 additions & 5 deletions packages/php-wasm/universal/src/lib/rethrow-file-system-error.ts
View file
Open in desktop
6 changes: 5 additions & 1 deletion packages/php-wasm/universal/src/lib/universal-php.ts
View file
Open in desktop
3 changes: 2 additions & 1 deletion packages/php-wasm/util/src/lib/index.ts
View file
Open in desktop
1 change: 0 additions & 1 deletion packages/playground/cli/src/mounts.ts
View file
Open in desktop
12 changes: 3 additions & 9 deletions packages/playground/cli/src/worker-thread.ts
View file
Open in desktop
1 change: 0 additions & 1 deletion ...ound/wordpress-builds/src/sqlite-database-integration/get-sqlite-driver-module-details.ts
View file
Open in desktop
6 changes: 3 additions & 3 deletions ...ordpress-builds/src/sqlite-database-integration/sqlite-database-integration-versions.json
View file
Open in desktop
Loading