Skip to content

Conversation

adamziel
Copy link
Collaborator

@adamziel adamziel commented Mar 17, 2023

Replaces the custom ts-api-reference-generator tool that built markdown with a more useful typedoc setup that generates an HTML site available at https://wordpress.github.io/wordpress-playground

@adamziel adamziel added [Type] Documentation Improvements or additions to documentation [Type] Developer Experience labels Mar 17, 2023
@adamziel adamziel force-pushed the api-doc-readability branch from 405ef10 to c543b16 Compare March 17, 2023 23:52
@adamziel adamziel merged commit 97d884d into trunk Mar 18, 2023
@adamziel adamziel deleted the api-doc-readability branch March 18, 2023 00:31
adamziel added a commit that referenced this pull request May 30, 2025
## Motivation for the change, related issues

Ensures URLs with data URL-based Blueprints, such as 

```
https://playground.wordpress.net?blueprint-url=data%3Aapplication%2Fjson%3Bbase64%2CeyJsYW5kaW5nUGFnZSI...
```

continue to work. They stopped working in
Automattic/wordpress-playground-private#75 due
to FetchFilesystem class. It assumed a non-data URL and constructed a
`new URL('./', baseUrl)` object in its constructor – which failed when
`baseUrl` was a data URL.

See
Automattic/wordpress-playground-private#157
for more details


## Testing Instructions (or ideally a Blueprint)

Confirm E2E tests pass – this PR ships a new one

Try [this
data URL
Blueprint](http://127.0.0.1:5400/website-server/?blueprint-url=data%3Aapplication%2Fjson%3Bbase64%2CeyJsYW5kaW5nUGFnZSI6Ii9mcmllbmRzLz9yZWZyZXNoJndlbGNvbWUiLCJmZWF0dXJlcyI6eyJuZXR3b3JraW5nIjp0cnVlfSwic3RlcHMiOlt7InN0ZXAiOiJta2RpciIsInBhdGgiOiJ3b3JkcHJlc3Mvd3AtY29udGVudC9tdS1wbHVnaW5zIn0seyJzdGVwIjoid3JpdGVGaWxlIiwicGF0aCI6IndvcmRwcmVzcy93cC1jb250ZW50L211LXBsdWdpbnMvYWRkRmlsdGVyLTEucGhwIiwiZGF0YSI6Ijw%2FcGhwIGFkZF9hY3Rpb24oICdyZXF1ZXN0cy1yZXF1ZXN0cy5iZWZvcmVfcmVxdWVzdCcsIGZ1bmN0aW9uKCAmJHVybCApIHtcbiR1cmwgPSAnaHR0cHM6Ly9wbGF5Z3JvdW5kLndvcmRwcmVzcy5uZXQvY29ycy1wcm94eS5waHA%2FJyAuICR1cmw7XG59ICk7In0seyJzdGVwIjoic2V0U2l0ZU9wdGlvbnMiLCJvcHRpb25zIjp7InBlcm1hbGlua19zdHJ1Y3R1cmUiOiIvJXBvc3RuYW1lJS8ifX0seyJzdGVwIjoiaW5zdGFsbFBsdWdpbiIsInBsdWdpbkRhdGEiOnsicmVzb3VyY2UiOiJ3b3JkcHJlc3Mub3JnL3BsdWdpbnMiLCJzbHVnIjoiZnJpZW5kcyJ9LCJvcHRpb25zIjp7ImFjdGl2YXRlIjp0cnVlfX0seyJzdGVwIjoicnVuUEhQIiwiY29kZSI6Ijw%2FcGhwIHJlcXVpcmVfb25jZSAnd29yZHByZXNzL3dwLWxvYWQucGhwJztcbmlmICggY2xhc3NfZXhpc3RzKCdGcmllbmRzXFxJbXBvcnQnKSkge1xuRnJpZW5kc1xcSW1wb3J0OjpvcG1sKFwiPD94bWwgdmVyc2lvbj1cXFwiMS4wXFxcIiBlbmNvZGluZz1cXFwidXRmLThcXFwiPz48b3BtbCB2ZXJzaW9uPVxcXCIyLjBcXFwiPlxuPGhlYWQ%2BXG48dGl0bGU%2BU3Vic2NyaXB0aW9uczwvdGl0bGU%2BXG48L2hlYWQ%2BXG48Ym9keT5cbjxvdXRsaW5lIHRleHQ9XFxcIlN1YnNjcmlwdGlvbnNcXFwiIHRpdGxlPVxcXCJTdWJzY3JpcHRpb25zXFxcIj5cbjxvdXRsaW5lIHR5cGU9XFxcInJzc1xcXCIgdGV4dD1cXFwiQWxleCBLaXJrXFxcIiB0aXRsZT1cXFwiQWxleCBLaXJrXFxcIiB4bWxVcmw9XFxcImh0dHBzOi8vYWxleC5raXJrLmF0XFxcIiBodG1sVXJsPVxcXCJodHRwczovL2FsZXgua2lyay5hdFxcXCIgLz5cbjxvdXRsaW5lIHR5cGU9XFxcInJzc1xcXCIgdGV4dD1cXFwiQWRhbSBaaWVsacWEc2tpXFxcIiB0aXRsZT1cXFwiQWRhbSBaaWVsacWEc2tpXFxcIiB4bWxVcmw9XFxcImh0dHBzOi8vYWRhbWFkYW0uYmxvZ1xcXCIgaHRtbFVybD1cXFwiaHR0cHM6Ly9hZGFtYWRhbS5ibG9nXFxcIiAvPlxuPC9vdXRsaW5lPlxuPC9ib2R5PlxuPC9vcG1sPlwiKTtcbn0ifV19)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Experience [Type] Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant