Skip to content

General: Prevent php warning for not readable files #9311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Ninos
Copy link

@Ninos Ninos commented Jul 23, 2025

Having unreadable php-files in theme-directory triggers following php-warning:

file_get_contents(/path/to/theme//maySubdir/file.php): Failed to open stream: No such file or directory in /wp-includes/class-wp-theme.php#L1333

This PR hardens the get_post_templates() function a bit.

Trac:
https://core.trac.wordpress.org/ticket/63743

Copy link

github-actions bot commented Jul 23, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ninos-ego, mindctrl.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Ninos Ninos force-pushed the feature/theme-templates-warning branch from 62b0266 to 2088397 Compare July 23, 2025 14:18
@mindctrl
Copy link

How would site admins, or log monitoring tools, know when there's a file read error if we suppress errors?

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@Ninos
Copy link
Author

Ninos commented Jul 23, 2025

How would site admins, or log monitoring tools, know when there's a file read error if we suppress errors?

For me such error output only makes sense for files which must be readable. The function parses all php-files in theme's subdirectories, not only template files, also which are not relevant for templating. Would be better to have some predefined folders (theme dir, /templates, ...) for parsing (also for performance reasons), but this would may break compatibility with some themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants