Skip to content

Twenty Fourteen: Fix dropdown menu touch support and accessibility issues #9291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from

Conversation

R1shabh-Gupta
Copy link

@R1shabh-Gupta R1shabh-Gupta commented Jul 21, 2025

Trac ticket: https://core.trac.wordpress.org/ticket/30575

Note
This PR is a continuation of PR #8820 and addresses additional issues outlined in Trac ticket #30575, comment 13.


Checklist

  • Fix: Sub-menu cannot be closed by clicking/tapping outside (like Twenty Sixteen behavior).
  • Fix: .focus class not applied when resizing screen after load below breakpoint (affects accessible focus styles).
  • Fix: Make CSS (783px) and JavaScript (781px) breakpoints consistent.
  • Add: Check if the menu exists before running the function to prevent issues in child themes or themes without menus.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@R1shabh-Gupta R1shabh-Gupta marked this pull request as ready for review July 24, 2025 09:27
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rishabhwp.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant