Query monitor: WordPress Playground compatibility #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accounts for the WordPress Playground runtime, where the sapi name is `cli` and the `$wpdb` variable [may not be available](https://github.com/WordPress/wordpress-playground/blob/c27a05386ce480c19a67be316d9bc093ffeec256/packages/playground/wordpress/src/index.ts#L391-L462).
adamziel
added a commit
that referenced
this pull request
Jul 24, 2025
Defining QM_TESTS in Playground is enough. See #215
adamziel
added a commit
that referenced
this pull request
Jul 24, 2025
#215 added a `QM_RUN_IN_CLI` check to enable running Query Monitor with the CLI sapi (it's always `cli` in Playground). Turns out, QM_TESTS is enough and shouldn't have any side-effects (at least in the current release). Let's roll back `QM_RUN_IN_CLI`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up in #212. Accounts for the WordPress Playground runtime, where the sapi name is
cliand the$wpdbvariable may not be available.Testing instructions
Just confirm it doesn't break CI. We don't have an easy way of running this PR in Playground (simply installing the plugin will trigger different code paths).