Add Gamepad API (rework) #88

ceyusa · 2021-09-23T10:35:18Z

Gamepad API in libwpe is middleware between WPEWebKit and the application, such as cog.

The application is reponsible to provide the gamepad backend, by offering the functions for providers and gamepads. While WPEWebkit shall provide event callbacks.

Original patch by Eugene Mutavchi Ievgen_Mutavchi@comcast.com (in MR #69)

aperezdc · 2021-09-28T18:21:18Z

We are late in the current development cycle to add new features (I am going to release 1.12.0 in the coming days), so let's slate this for 1.14 🕐

ceyusa · 2022-02-10T12:11:00Z

v2:

Added API to provide the view_backend from application to webkit

donny-dont · 2022-03-18T17:38:56Z

I'm wondering if like in #94 there should be a WPE_ENABLE_GAMEPAD along with this PR so it can be toggled on and off

aperezdc · 2022-03-24T15:13:35Z

@ceyusa This would need a rebase, bonus points if #99 could be merged first so we would get the new checks on the code touched by this PR already 😉

aperezdc

Overall approach looks fine, but I have a bunch of small nits (please bear with me! 🐻)

src/gamepad.c

include/wpe/gamepad.h

src/gamepad.c

ceyusa · 2022-04-07T19:43:33Z

I'm wondering if like in #94 there should be a WPE_ENABLE_GAMEPAD along with this PR so it can be toggled on and off

I don't think it's the case since xkbcommon meant a dependency, and it this case there's no new dependencies.

aperezdc

I have only a minor nit before landing this, thanks for the update!

Also, the style checker is complaining. This can be used to apply its suggestions to your work branch:

./scripts/check-style master | git apply -p0

src/gamepad.c

ceyusa · 2022-05-09T09:41:15Z

Also, the style checker is complaining. This can be used to apply its suggestions to your work branch:

Sorry! I lost track of this. I'm terrible juggling with context switching :)

donny-dont

Just had one nit. Other than that would be great to land this.

include/wpe/gamepad.h

Gamepad API in libwpe is middleware between WPEWebKit and the application, such as cog. The application is reponsible to provide the gamepad backend by offering the functions for providers and gamepads. WPEWebkit shall provide event callbacks. Original patch by Eugene Mutavchi <Ievgen_Mutavchi@comcast.com>

aperezdc

From my point of view, this is ready to merge. I'll leave some time for others to comment beforehand, just in case there might be objections (unlikely, I suppose!)

donny-dont · 2022-05-10T20:15:10Z

I'm positive on this change as well. Thanks @ceyusa can't wait to use it.

Could we potentially have a dev release cut after this lands?

aperezdc · 2022-05-10T20:54:22Z

I'm positive on this change as well. Thanks @ceyusa can't wait to use it.

Could we potentially have a dev release cut after this lands?

SGTM, I can put out a development release right after.

aperezdc · 2022-05-12T19:55:05Z

There hasn't been further comments for a couple of days, so let's get this merged. Note that if we wanted (or needed) to refine these changes, we still have time to make follow-up fixes until September 2022 when the next stable series is due.

https://bugs.webkit.org/show_bug.cgi?id=230630 With gamepad support in libwpe[1] is possible to communicate gamepads events between the application (cog, for example) and WPEWebKit. This patch are the changes required to attend that communication and enable the gamepad support in WPE port. 1. WebPlatformForEmbedded/libwpe#88 Reviewed by Adrian Perez de Castro. * LayoutTests/platform/wpe/TestExpectations: Enable skipped tests. * Source/WebCore/PlatformWPE.cmake: Add headers if enabled. * Source/WebCore/SourcesWPE.txt: Add source files. * Source/WebCore/platform/gamepad/wpe/WPEGamepad.cpp: Added. (WebCore::WPEGamepad::WPEGamepad): (WebCore::WPEGamepad::~WPEGamepad): (WebCore::WPEGamepad::buttonPressedOrReleased): (WebCore::WPEGamepad::absoluteAxisChanged): * Source/WebCore/platform/gamepad/wpe/WPEGamepad.h: Added. * Source/WebCore/platform/gamepad/wpe/WPEGamepadProvider.cpp: Added. (WebCore::WPEGamepadProvider::singleton): (WebCore::WPEGamepadProvider::WPEGamepadProvider): (WebCore::WPEGamepadProvider::~WPEGamepadProvider): (WebCore::WPEGamepadProvider::startMonitoringGamepads): (WebCore::WPEGamepadProvider::stopMonitoringGamepads): (WebCore::WPEGamepadProvider::gamepadConnected): (WebCore::WPEGamepadProvider::gamepadDisconnected): (WebCore::WPEGamepadProvider::indexForNewlyConnectedDevice): (WebCore::WPEGamepadProvider::removeGamepadForId): (WebCore::WPEGamepadProvider::initialGamepadsConnectedTimerFired): (WebCore::WPEGamepadProvider::inputNotificationTimerFired): (WebCore::WPEGamepadProvider::scheduleInputNotification): (WebCore::WPEGamepadProvider::inputView): * Source/WebCore/platform/gamepad/wpe/WPEGamepadProvider.h: Added. * Source/WebKit/SourcesWPE.txt: Add source files. * Source/WebKit/UIProcess/API/wpe/WPEView.cpp: Reports the view where gamepad currently operates. (WKWPE::m_backend): (WKWPE::View::~View): (WKWPE::View::setViewState): (WKWPE::View::platformWebPageProxyForGamepadInput): * Source/WebKit/UIProcess/API/wpe/WPEView.h: * Source/WebKit/UIProcess/Gamepad/UIGamepadProvider.cpp: * Source/WebKit/UIProcess/Gamepad/wpe/UIGamepadProviderWPE.cpp: Added. (WebKit::UIGamepadProvider::platformSetDefaultGamepadProvider): (WebKit::UIGamepadProvider::platformWebPageProxyForGamepadInput): (WebKit::UIGamepadProvider::platformStopMonitoringInput): (WebKit::UIGamepadProvider::platformStartMonitoringInput): * Source/cmake/OptionsWPE.cmake: Canonical link: https://commits.webkit.org/253720@main

https://bugs.webkit.org/show_bug.cgi?id=230630 With gamepad support in libwpe[1] is possible to communicate gamepads events between the application (cog, for example) and WPEWebKit. This patch are the changes required to attend that communication and enable the gamepad support in WPE port. 1. WebPlatformForEmbedded/libwpe#88 Reviewed by Adrian Perez de Castro. * LayoutTests/platform/wpe/TestExpectations: Enable skipped tests. * Source/WebCore/PlatformWPE.cmake: Add headers if enabled. * Source/WebCore/SourcesWPE.txt: Add source files. * Source/WebCore/platform/gamepad/wpe/WPEGamepad.cpp: Added. (WebCore::WPEGamepad::WPEGamepad): (WebCore::WPEGamepad::~WPEGamepad): (WebCore::WPEGamepad::buttonPressedOrReleased): (WebCore::WPEGamepad::absoluteAxisChanged): * Source/WebCore/platform/gamepad/wpe/WPEGamepad.h: Added. * Source/WebCore/platform/gamepad/wpe/WPEGamepadProvider.cpp: Added. (WebCore::WPEGamepadProvider::singleton): (WebCore::WPEGamepadProvider::WPEGamepadProvider): (WebCore::WPEGamepadProvider::~WPEGamepadProvider): (WebCore::WPEGamepadProvider::startMonitoringGamepads): (WebCore::WPEGamepadProvider::stopMonitoringGamepads): (WebCore::WPEGamepadProvider::gamepadConnected): (WebCore::WPEGamepadProvider::gamepadDisconnected): (WebCore::WPEGamepadProvider::indexForNewlyConnectedDevice): (WebCore::WPEGamepadProvider::removeGamepadForId): (WebCore::WPEGamepadProvider::initialGamepadsConnectedTimerFired): (WebCore::WPEGamepadProvider::inputNotificationTimerFired): (WebCore::WPEGamepadProvider::scheduleInputNotification): (WebCore::WPEGamepadProvider::inputView): * Source/WebCore/platform/gamepad/wpe/WPEGamepadProvider.h: Added. * Source/WebKit/SourcesWPE.txt: Add source files. * Source/WebKit/UIProcess/API/wpe/WPEView.cpp: Reports the view where gamepad currently operates. (WKWPE::m_backend): (WKWPE::View::~View): (WKWPE::View::setViewState): (WKWPE::View::platformWebPageProxyForGamepadInput): * Source/WebKit/UIProcess/API/wpe/WPEView.h: * Source/WebKit/UIProcess/Gamepad/UIGamepadProvider.cpp: * Source/WebKit/UIProcess/Gamepad/wpe/UIGamepadProviderWPE.cpp: Added. (WebKit::UIGamepadProvider::platformSetDefaultGamepadProvider): (WebKit::UIGamepadProvider::platformWebPageProxyForGamepadInput): (WebKit::UIGamepadProvider::platformStopMonitoringInput): (WebKit::UIGamepadProvider::platformStartMonitoringInput): * Source/cmake/OptionsWPE.cmake: Canonical link: https://commits.webkit.org/253720@main (cherry picked from commit ab0e247)

ceyusa force-pushed the gamepad branch from da8088f to ea4e245 Compare September 23, 2021 10:36

ceyusa mentioned this pull request Sep 23, 2021

Add gamepad implementation. Igalia/cog#361

Merged

aperezdc added this to the 1.14 milestone Sep 28, 2021

aperezdc mentioned this pull request Sep 28, 2021

Gamepad API #69

Closed

aperezdc added the enhancement label Sep 28, 2021

ceyusa force-pushed the gamepad branch from ea4e245 to 48bd496 Compare February 10, 2022 12:09

aperezdc requested changes Mar 24, 2022

View reviewed changes

donny-dont reviewed Mar 24, 2022

View reviewed changes

src/gamepad.c Outdated Show resolved Hide resolved

ceyusa force-pushed the gamepad branch 2 times, most recently from bba235d to 5b43554 Compare April 19, 2022 15:44

aperezdc requested changes May 2, 2022

View reviewed changes

src/gamepad.c Outdated Show resolved Hide resolved

ceyusa force-pushed the gamepad branch 2 times, most recently from 896d166 to cd2790a Compare May 9, 2022 09:39

donny-dont reviewed May 9, 2022

View reviewed changes

include/wpe/gamepad.h Outdated Show resolved Hide resolved

ceyusa force-pushed the gamepad branch from cd2790a to 17e8995 Compare May 9, 2022 18:36

aperezdc approved these changes May 10, 2022

View reviewed changes

aperezdc merged commit dad8942 into WebPlatformForEmbedded:master May 12, 2022

ceyusa deleted the gamepad branch May 23, 2022 12:25

ceyusa mentioned this pull request May 23, 2022

[WPE] Add gamepad support WebKit/WebKit#911

Merged

magomez mentioned this pull request May 25, 2022

Gamepad for WPE WebPlatformForEmbedded/WPEWebKit#692

Closed

Add Gamepad API (rework) #88

Add Gamepad API (rework) #88

Uh oh!

Conversation

ceyusa commented Sep 23, 2021

Uh oh!

aperezdc commented Sep 28, 2021

Uh oh!

ceyusa commented Feb 10, 2022

Uh oh!

donny-dont commented Mar 18, 2022

Uh oh!

aperezdc commented Mar 24, 2022

Uh oh!

aperezdc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ceyusa commented Apr 7, 2022

Uh oh!

aperezdc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ceyusa commented May 9, 2022

Uh oh!

donny-dont left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aperezdc left a comment

Choose a reason for hiding this comment

Uh oh!

donny-dont commented May 10, 2022

Uh oh!

aperezdc commented May 10, 2022

Uh oh!

aperezdc commented May 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants