Release/3.1 469 - Display non-standard params warning #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we better highlight non default params since they affect the default score. - Display non-default params table in the summary view - Simplify defaultParams creation code a bit - Rebuild news-next since params.mjs changed
✅ Deploy Preview for webkit-speedometer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
camillobruni
requested review from
julienw and
rniwa
and removed request for
rniwa
Contributor
Author
|
Sorry, forgot to request for reviews. This is still up... but also ok if we don't merge it. |
Contributor
|
Honestly this feels like a too big change so close to the release. But if you folks feel differently I'd be happy to look at it closer. |
Contributor
Author
|
I feel a bit the same here. I could have ported the core UI changes without the params part, but that meant a whole lot of untested code again.... let's abandon this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #489 for 3.1.
This is a modified cherry-pick of #469: