-
Notifications
You must be signed in to change notification settings - Fork 38
Add on-device speech recognition support to the Web Speech API #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hoch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits
KuayMongkolchai7726
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank Your
| undefined start(MediaStreamTrack audioTrack); | ||
| undefined stop(); | ||
| undefined abort(); | ||
| boolean onDeviceWebSpeechAvailable(DOMString lang); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a first glance, this property looks like an event due to the "on" prefix.
A way to avoid that misinterpretation would be to prepend another prefix to the name, e.g. isOnDeviceWebSpeechAvailable.
P.S. This is random feedback that does not carry any weight. I just read this proposal out of interest and noticed this.
Closes #108
This PR updates the Web Speech API spec to include support for on-device speech recognition.