Skip to content

Conversation

@evanbliu
Copy link
Collaborator

Closes #108

This PR updates the Web Speech API spec to include support for on-device speech recognition.

@evanbliu evanbliu requested a review from hoch January 3, 2025 21:37
Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

@evanbliu evanbliu merged commit d357d3c into WebAudio:main Jan 6, 2025
@evanbliu evanbliu deleted the OnDeviceWebSpeech branch January 6, 2025 23:02
Copy link

@KuayMongkolchai7726 KuayMongkolchai7726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank Your

undefined start(MediaStreamTrack audioTrack);
undefined stop();
undefined abort();
boolean onDeviceWebSpeechAvailable(DOMString lang);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a first glance, this property looks like an event due to the "on" prefix.

A way to avoid that misinterpretation would be to prepend another prefix to the name, e.g. isOnDeviceWebSpeechAvailable.

P.S. This is random feedback that does not carry any weight. I just read this proposal out of interest and noticed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Offline/on-device speech recognition

5 participants