Improve some pthreads stub functions, batch 0 #519
Merged
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Open Group Base Specifications does not list this as an optional function Return EINVAL for anything that isn't 0
The Open Group Base Specifications list init and destroy as required
{get|set}pshared aren't required nor useful as WASI doesn't have subprocesses
nor the ability to remap multiple virtual memory pages to the same contents.
However, for consistency with other types, provide them as stubs.
sbc100
approved these changes
Jul 31, 2024
Contributor
Author
|
I don't have the ability to merge this, do we need more reviewers or does somebody just need to click the button? |
yamt
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one part of breaking up #518 into smaller PRs. This should be (IMO) the least-controversial batch of commits