Add support for __main_argc_argv.
#152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
force-pushed
the
main-changes
branch
from
50f0e78 to
d15aaca
Compare
peterhuene
approved these changes
Feb 24, 2020
This was referenced Feb 24, 2020
This adds support for the `__main_argc_argv` change, while preserving compatibility with `__original_main`. This is needed by the LTO build because the `__original_main` hack works in LLVM codegen, which is after LTO. The `__main_argc_argv` change is implemented in clang, which makes it properly visible to LTO.
sunfishcode
force-pushed
the
main-changes
branch
from
d15aaca to
8638ab9
Compare
Member
Author
|
With WebAssembly/tool-conventions#134 and https://reviews.llvm.org/D70700 merged, it's time to merge this too! 🏄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the
__main_argc_argvchange, while preservingcompatibility with
__original_main. This is needed by the LTO buildbecause the
__original_mainhack works in LLVM codegen, which is afterLTO. The
__main_argc_argvchange is implemented in clang, which makesit properly visible to LTO.