Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Jan 24, 2016

To resolve #210

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: formatting seems off.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no style guide for the formatting of s-exp. Putting trailing braces on separate lines is what I see beginners do and once people have a little experience they prefer the increased information density of placing them on one line - you will not find experienced lisp codes putting closing braces on separate lines as a style rule (there are some exceptions, but not for something so simple as above).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring to the inconsistent indentation and the extra line breaks in particular. That said, it's good practice for changes to adapt to surrounding styles. ;)

@sunfishcode
Copy link
Member

lgtm

@sunfishcode
Copy link
Member

This branch needs a merge conflict resolution.

@rossberg
Copy link
Member

Ping @JSStats, can you resolve the merge conflict?

@ghost
Copy link
Author

ghost commented Feb 25, 2016

ptal

rossberg added a commit that referenced this pull request Feb 25, 2016
Add a test of block label redefinition.
@rossberg rossberg merged commit 4b4e50c into WebAssembly:master Feb 25, 2016
@ghost ghost deleted the label-redef branch February 25, 2016 10:24
dhil pushed a commit to dhil/webassembly-spec that referenced this pull request Mar 2, 2023
Fixes WebAssembly#215.

This should indicate that an engine is still conforming if it does not attach a stack trace, even if `traceStack` is requested by JavaScript code (by setting it to `true`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document behavior of label name reuse.
2 participants