Editorial: replace Type AO with new ECMA-262 type test convention #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @eqrion. Also the CI seems to be broken in this repo. |
|
Thanks! I'll try to take a look at CI soon. I also just need to get this merged upstream too. |
eqrion
pushed a commit
that referenced
this pull request
Jun 25, 2025
These tests appear adapted with memory64 with overlong LEB-encodings but when merged with the upstream spec test suite the function length is too short. By ensuring the function length is correct it ensures that the only error in the module is the overlong LEB encoding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECMA-262 now uses these prose forms for type tests and has removed the old Type AO. See WebAssembly/spec#1842 for more info.